Website

All pending tasks and bugs related to the website.
Tasklist

FS#4685 - Don't allow old scenarios

Attached to Project: Website
Opened by FooBar (foobar) - Wednesday, 13 July 2011, 18:46 GMT
Last edited by Remko Bijker (Rubidium) - Saturday, 30 July 2011, 07:03 GMT
Type Bug
Category BaNaNaS
Status New
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Due to this topic: http://www.tt-forums.net/viewtopic.php?f=31&t=55737&p=956922#p956922

Problem:
When starting a very old scenario (via Play Scenario), the game loads all NewGRFs configured in the main menu into that scenario. In multiple situations this will give major problems.

Example:
"BigRiver" and "Rusty Paradise" scenarios from the content download (both savegame version 13,1). The Play Scenario window reports that no newgrfs are used in these scenarios (what appears to be indeed the case). However, when playing either scenario, the game loads all NewGRFs configured in the main menu into the scenario. In my opinion, if there is no information on used NewGRFs in a savegame, the game should load no NewGRFs at all.
This task depends upon

Comment by Remko Bijker (Rubidium) - Wednesday, 13 July 2011, 19:05 GMT
Let me state another, related problem:

Imagine savegames (and thus scenarios) made in a time that NewGRF information were not stored in the savegame, but taken from the global settings. Now loading those savegames in a later version makes them fail to load because of missing NewGRFs, messing up the savegame enormously. As extra caveat: adding NewGRFs after loading the savegame does not help; the savegame is already destroyed by loading it without NewGRFs.

How would you solve this problem? Your problem is the only solution.
Comment by FooBar (foobar) - Wednesday, 13 July 2011, 19:44 GMT
Valid point. I suppose there's no way to detect if there are or are not NewGRFs used in a savegame (without determining which ones exactly)?

Otherwise I like to recommend disallowing scenarios to be uploaded which have a savegame version lower than whatever version that introduced remembering what NewGRFs are used. That will at least reduce the chance of someone running into this problem. Preferrably including converting/removing existing scenarios with this problem.

Loading...