FS#4684 - Use shift to estimate costs only with a certain type of commands

Attached to Project: OpenTTD
Opened by Grzegorz Duczyński (adf88) - Wednesday, 13 July 2011, 08:19 GMT
Type Patch
Category Core
Status New
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


This patch makes the shift key more usable by narrowing the set of commands in which we can estimate costs.

For the set I chose CMDT_LANDSCAPE_CONSTRUCTION and CMDT_VEHICLE_CONSTRUCTION commands. These are the only commands that costs us money and after firing them we can see on the map a floating price drawn red (this rule is very clear). Other commands that have to do with our money are CMDT_MONEY_MANAGEMENT, but these are actually costless and cost estimation returns 0 anyway (and we can't see a floating price drawn red after firing them).

The patch is related to (it's a suggestion to) FS4668
This task depends upon

Comment by Peter Nelson (peter1138) - Tuesday, 14 March 2017, 00:07 GMT
Doesn't this break a usability rule that pressing shift will not actually execute anything?
Comment by Grzegorz Duczyński (adf88) - Sunday, 02 April 2017, 10:59 GMT
No, because there is no such rule i.e. shift-clicking on jukebox "play" button WILL execute the action.

The patch narrows the affected area from "actions that change game state" to "actions that involve buying/building something".