FS#4678 - Wrong handling of newgrf canal variable 0x80

Attached to Project: OpenTTD
Opened by Grzegorz DuczyƄski (adf88) - Saturday, 09 July 2011, 09:51 GMT
Last edited by frosch (frosch) - Sunday, 10 July 2011, 13:04 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When reading newgrf canal variable 0x80, there is in the code a condition:
"GetSection(tile) == LOCK_UPPER"
This condition is never fulfilled as GetSection read first 4 bits of tile's m5 and the LOCK_UPPER is 0x1C.

Fix patch attached (requires FS 4673)
This task depends upon

Closed by  frosch (frosch)
Sunday, 10 July 2011, 13:04 GMT
Reason for closing:  Fixed
Additional comments about closing:  in r22645