Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: vehicle control enhancements #4668

Closed
DorpsGek opened this issue Jul 1, 2011 · 4 comments
Closed

patch: vehicle control enhancements #4668

DorpsGek opened this issue Jul 1, 2011 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jul 1, 2011

blup opened the ticket and wrote:

Provide to the user a more fine grained mouse-to-vehicles interactions configuration. Features:

  1. provides the user a way of enabling and disabling the capability to start and stop vehicles when ctrl-clicking them.
  2. provides the user a way to control the behaviours of ctrl+left-click, shift+left-click and ctrl+shift+left-click when giving orders to vehicles (only when the goto tool is active). They can be configured to either "full load any cargo", "transfer cargo, "force unload cargo" or "no-action".
    2a) original OpenTTD behaviours are kept as default.
  3. provides the user a way of enabling and disabling the insertion of "no-loading" load type when giving an order transfer or unload-all unload types.
  4. adds "Advanced Settings->Vehicles->Controls & Orders" sub-page.
    4a) moves "New orders are 'non-stop' by default" into it.
  5. adds "Advanced Settings->Vehicles->Controls & Orders->Order Shortcuts" sub-page.
  6. adds english STR_CONFIG_SETTING_... strings to every language files. // VOIDED
  7. adds "Advanced Settings->Vehicles->Controls & Orders->Hide implicit orders"
  8. modify src/order_gui.cpp code so it does not cause network and save-game de-sync when (7) is enabled.

Works with trunk (r22612) and 1.1.1 using the proper patch.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4668
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2011

planetmaker wrote:

Interesting idea.

- Just a note: # 6) is not needed and should be left out. Only english.txt should be changed and especially never English strings added to other language files. All translations are done via our web translator by the respective translators, strings are added there automatically, if translated.
- A patch against 1.1 branch is not needed. Development happens in trunk (only)
- There are two, three occasions where an empty line is added or removed but nothing else
- Please add doxygen documentation to all newly introduced procedures and functions. This documentation goes directly above them in the implementation. See http://wiki.openttd.org/Coding_style# Documentation and documented functions in the source
- Things like "+ else { /* uh ho! */ }" are not helpful

This comment was imported from FlySpray: https://bugs.openttd.org/task/4668#comment10040

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2011

blup wrote:

I will update the patches as soon I am done with # 4665. For the 1.1.1 patch, it has only been released for the players who would be interested to have the features right now.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4668#comment10041

@DorpsGek
Copy link
Member Author

adf88 wrote:

I have a suggestion to shift key handling: FS4684

This comment was imported from FlySpray: https://bugs.openttd.org/task/4668#comment10062

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4668

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek