Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewGRF can't disable playing a sound effect in CB 33. #4656

Closed
DorpsGek opened this issue Jun 23, 2011 · 1 comment
Closed

NewGRF can't disable playing a sound effect in CB 33. #4656

DorpsGek opened this issue Jun 23, 2011 · 1 comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Hirundo opened the ticket and wrote:

r22607

The specification of CB 33 states the following:
"If the callback returns a sound number that is neither a TTD sound, nor a sound from action 11, nothing will be played."

OpenTTD seems to act differently. In PlayVehicleSound (newgrf_sound.cpp:54), false is returned if the sound ID specified by the grf is bogus. This instructs the caller to play the default sound. Instead the function should return true in this case, in order to not play the default sound.

Attached patch fixes this.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4656
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2011

frosch closed the ticket.

Reason for closing: Fixed

in r22614


This comment was imported from FlySpray: https://bugs.openttd.org/task/4656

@DorpsGek DorpsGek closed this as completed Jul 2, 2011
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant