Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orders sometimes skipped #4641

Closed
DorpsGek opened this issue Jun 13, 2011 · 3 comments
Closed

orders sometimes skipped #4641

DorpsGek opened this issue Jun 13, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

See the attached savegame and look at the orders of the train approaching the station. Active order is currently # 8. When it decides to go to the left track of the station it suddenly jumps to order 1.

Attachments

Reported version: 1.1.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4641
@DorpsGek
Copy link
Member Author

Troy_McClure wrote:

The oddity only seems to occur when there's a PBS (oneway or twoway) in front of the station. After removing the twoway PBS in front of the station tracks, the same problem still occurred. The oddity did NOT occur when using presignals (oneway entry signal, twoway exit signal).


This comment was imported from FlySpray: https://bugs.openttd.org/task/4641#comment10001

@DorpsGek
Copy link
Member Author

frosch wrote:

VehicleOrderSaver::SwitchToNextOrder() calls UpdateOrderDest() for depot, station and waypoint-orders.

This function has the sideeffect to change the order index in two cases:

  1. It is called for a service-only depot order, but the vehicle does not need service.
  2. It is called for a goto-nearest-depot order, but no depot can be found.

Case 1 is cought in advance by SwitchToNextOrder(), case 2 is not.
Case 2 is triggered in this game.

This bug is present since PBS.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4641#comment10003

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r22589


This comment was imported from FlySpray: https://bugs.openttd.org/task/4641

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant