Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent industries - not so transparent #4626

Closed
DorpsGek opened this issue May 26, 2011 · 3 comments
Closed

Transparent industries - not so transparent #4626

DorpsGek opened this issue May 26, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Jubilee opened the ticket and wrote:

There are some issues when industries are made transparent or are totally hidden from view. I'm posting them all in one task as i think they are all related.

Steel Mill, Iron Ore Mine and Factory are not completely transparent/hidden. Parts of them that are on their base tiles are shown as if they were not transparent/hidden.

Also, it seems that Farm, Coal Mine and Oil Wells are not as hidden as other industries when "totally hidden from view" is selected. Not that it matters but i mention it because i'm not sure if it's intentional or not.

Reported version: 1.1.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4626
@DorpsGek
Copy link
Member Author

planetmaker wrote:

I'm not sure which base graphics you refer to (TTD or OpenGFX (which version?) or both).

However, it's not really an OpenTTD bug:

a) The TTD base set handles the industries you mention indeed in a bad way, but that's a "feature" which is inherited from TTD. The ground sprites, of e.g. factory and steel mill just show the building cut to the tile borders; as no one can fix the TTD base set, that will stay; only other base sets can try to do better there, OpenGFX (as of version 0.3.4, see screenshots for comparison) addresses the issue of improperly cut sprites (somewhat) for all those industries you mention - with two exception: Surely it can still be improved but, but well any help and contributions here are warmely welcome :-). Coal mine will need a review for that and can be fixed, but not the iron ore mine, for a 2nd, nasty reason:

b) Further, from we inherited the way when and how a certain sprite must be used to show an industry, how the base graphics compose an item. This latter thing cannot be fixed for any base set; it unfortunatly dictates the repetitive use of certain ground tiles with base graphics in MANY occasions where it might not be seen as desirable. The iron ore mine only consists of ground sprites and simply has no building sprites, thus always has to show the same thing.

c) NewGRFs, of course, have all freedom and can handle everything properly.

We cannot (easily) change (a) as it might break existing NewGRFs. There might be a way around (a) without breaking NewGRFs, but that's very lengthy: you need to make sure that no NewGRF modifies the sprites used by the industry and neither one of the used industry tiles. And only in that case you could then introduce a new version of the related industry tiles which make proper use of ground and building sprites. But this check is not trivial.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4626#comment9964

@DorpsGek
Copy link
Member Author

Jubilee wrote:

Sorry i didn't associate these issues with the graphics engine. I'm using OpenGFX 0.3.3.

As you can see i marked this issue as having a "Very low" severity, because i just noticed and considered them purely cosmetic bugs. Of course there's no point in putting too much effort on these, especially if they are complex to resolve. As i understand though, some improvements are made with OpenGFX, which is nice.

Thanks for all the info. I guess this issue may be closed...


This comment was imported from FlySpray: https://bugs.openttd.org/task/4626#comment9965

@DorpsGek
Copy link
Member Author

planetmaker closed the ticket.

Reason for closing: Requested by user

Sprites are provided by the base sets, which will need to fix those issues. The graphics base set OpenGFX is external to OpenTTD but can be modified; patches, graphics, ... are warmly welcome.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4626

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant