Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs when importing an original TT savegame #4622

Closed
DorpsGek opened this issue May 22, 2011 · 10 comments
Closed

Bugs when importing an original TT savegame #4622

DorpsGek opened this issue May 22, 2011 · 10 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Jubilee opened the ticket and wrote:

When loading the attached Original TT savegame, the following things happen:

- After loading the game in OpenTTD, the user must manually change all the servicing intervals because they are all set to disabled (instead of the defaults for each vehicle type), causing all vehicles to eventually drop down to 0% in reliability.

- Some train wagons are not properly translated (i.e. Train 4 is composed of coal trucks but in the train info panel they show as mail vans, while in the capacities they show as carrying coal). Cloning the train produces mail vans. In another train (train 12), the mail vans are wrongly shown as coal trucks in the info panel, even though in the capacities they are shown as carrying mail.

Attachments

Reported version: 1.1.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4622
@DorpsGek
Copy link
Member Author

SmatZ wrote:

Mail wagons are loaded as coal ones as well, strange.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9945

@DorpsGek
Copy link
Member Author

Jubilee wrote:

Thanks for the fix, but there's no comment for the following:

"After loading the game in OpenTTD, the user must manually change all the servicing intervals because they are all set to disabled (instead of the defaults for each vehicle type), causing the reliability of all vehicles to eventually drop down to 0%."

I assume there's no fix about it, right?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9947

@DorpsGek
Copy link
Member Author

frosch wrote:

Haha, yeah, that's what you get for putting two things in one task :p Sorry :)

Wrt. the first issue: _old_vds is never initialised when loading TTD or TTO savegames.
Loading a 0.7.x savegame first and the loading a TTO/TTD savegame makes it use of the company settings from the 0.7.x game.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9948

@DorpsGek
Copy link
Member Author

Jubilee wrote:

Haha, yeah, that's what you get for putting two things in one task

Yup, i thought of that after i had posted the task. :) Sorry for it.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9949

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 3, 2011

Jubilee wrote:

OpenTTD 1.1.1

"After loading the game in OpenTTD, the user must manually change all the servicing intervals because they are all set to disabled (instead of the defaults for each vehicle type), causing all vehicles to eventually drop down to 0% in reliability."

This seems to have been resolved. Thanks.

"Some train wagons are not properly translated (i.e. Train 4 is composed of coal trucks but in the train info panel they show as mail vans, while in the capacities they show as carrying coal). Cloning the train produces mail vans. In another train (train 12), the mail vans are wrongly shown as coal trucks in the info panel, even though in the capacities they are shown as carrying mail"

This one still exists. Train 4 for instance should have coal cars but instead in the train info, it seems to have mail vans. I thought this one was fixed... :(


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9981

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 3, 2011

Jubilee wrote:

Sorry, my mistake. Both issues are unresolved in 1.1.1...


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9982

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 3, 2011

Yexo wrote:

The commit that fixed that (r22498: - Fix: Engine IDs for coal and mail wagons were swapped in the TTO savegame conversion) was not backported to 1.1.1. It should be fixed in trunk and the fix will also be in the upcoming 1.1.2-RC1 release.

Was the servicing interval bug fixed at all? I thought that was the reason this bug report is still open.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9983

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 3, 2011

frosch wrote:

Yexo is correct. The service interval is not fixed yet, thus the task is still open.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9984

@DorpsGek
Copy link
Member Author

DorpsGek commented Jun 4, 2011

Jubilee wrote:

No,it wasn't. My mistake. The service interval on the info of each train is the usual 150 days, that's why i got tricked and thought it was fixed. If you go in Options, all service intervals of all vehicle types are still set to "disabled".

Sorry about the re-reports. I thought that when a bug was marked as "fixed", it would be included in the next release. I didn't know the process.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622#comment9985

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 3, 2011

frosch closed the ticket.

Reason for closing: Fixed

in r22626 (the service interval issue)


This comment was imported from FlySpray: https://bugs.openttd.org/task/4622

@DorpsGek DorpsGek closed this as completed Jul 3, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant