Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful disconnects impossible on Windows OpenTTD servers #4601

Closed
DorpsGek opened this issue Apr 27, 2011 · 1 comment
Closed

Graceful disconnects impossible on Windows OpenTTD servers #4601

DorpsGek opened this issue Apr 27, 2011 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

xOR opened the ticket and wrote:

I tested with the following scenario:
- start a local dedicated OpenTTD server (run openttd.exe with -D option), no NewGRFs or patches
- start vanilla OpenTTD client on the same machine
- connect the client to the server, wait some seconds to make sure everything is running normal
- disconnect the client through various ways:
- choose "Quit game" from the menu so the client goes back to the main menu
- enter "quit" in console
- close the window and confirm the message box

I tested it on both Windows XP Prof. 32 Bit and Windows 7 64 Bit and never got a single graceful quit in 15 tries on each system (so overall 30 tries). It will always end up like this:
dbg: [net] recv failed with error 10054
*** xOR has left the game (connection lost)
dbg: [net] Closed client connection 9

The same tests on a Linux server also show a quite high rate of socket error quits but at least there it is possible to leave gracefully (the server showing "leaving" as quit message).

The latter problem could get fixed by the client sleeping a short time between sending the QUIT packet and shutting down its socket (e.g. 100 ms wouldn't be noticed by any user but make the socket shutdown much more clean).

Reported version: 1.1.0
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/4601
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r22387


This comment was imported from FlySpray: https://bugs.openttd.org/task/4601

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant