Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findversion.sh with Mercurial Patch Queue support #4588

Closed
DorpsGek opened this issue Apr 11, 2011 · 3 comments
Closed

findversion.sh with Mercurial Patch Queue support #4588

DorpsGek opened this issue Apr 11, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Ammler opened the ticket and wrote:

since we added tag support for mercurial to findversion.sh, the version looks quite silly, as the patches are also tags. This patch adds MQ support and removes also the requirement of hgsubversion for svn revision detection.

patch should work for trunk and branch 1.1

History: http://dev.openttdcoop.org/projects/clientpatches/repository/changes/supportPatchQueue.diff

P.S. As I have no access to MSVC, I am not able to patch the detection for it, also I am not brave enough to guess it. :-)

the current version is not broken, just ugly together with MQ and bit slower as it does grep the whole history for svn revision. I think it is fine enough to keep the old version for findversion.vbs and wait until a MSVC/HG user rises up. ;-)

Attachments

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4588
@DorpsGek
Copy link
Member Author

Ammler wrote:

just saw, the patch has still old comment:

"- don't grep the whole history log, if hgsubversion is available" <-- just ignore "if hgsubversion is available", it works now without

This comment was imported from FlySpray: https://bugs.openttd.org/task/4588#comment9874

@DorpsGek
Copy link
Member Author

Ammler wrote:

tags are randomly sorted, this fixes that

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4588#comment9884

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4588

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek