FS#4585 - ADMIN_PACKET_SERVER_CLIENT_ERROR not sent when client loses connection

Attached to Project: OpenTTD
Opened by Yorick (yorick) - Saturday, 09 April 2011, 20:37 GMT
Last edited by Remko Bijker (Rubidium) - Saturday, 30 April 2011, 12:09 GMT
Type Bug
Category Network → Admin
Status Closed
Assigned To No-one
Operating System All
Severity Medium
Priority Normal
Reported Version 1.1.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When a client loses connection, any connected admins are not notified about the error, which leaves them unable to find out that the client is no longer there without nonautomatic updates or console forwarding. Further investigation revealed that "NetworkAdminClientError(this->client_id, NETWORK_ERROR_CONNECTION_LOST);" is missing from ServerNetworkGameSocketHandler::CloseConnection.
This task depends upon

Closed by  Remko Bijker (Rubidium)
Saturday, 30 April 2011, 12:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r22384
Comment by xOR (xOR) - Saturday, 02 July 2011, 20:48 GMT
the fix is in trunk but was also listed on the changelog for 1.1.1-RC1, yet didn't go into the 1.1.1 release. just noting it here so others don't do the same like me: search the bug in their program for an hour just to notice that it's OpenTTD which simply isn't sending the packet :(
Comment by frosch (frosch) - Saturday, 02 July 2011, 21:40 GMT
confirmed, readded for 1.1.2-RC1