Belugas wrote:

1. Those not in "correct" order are additions from original data, installed as they were required either by users or by devs
   So it's the rule of first requested first delivered for those not ordered.
   As to reorder them, no, it's not going to happen since they are following the ID they were assigned at creation time.
   Changing the order would actually break stuff big time

2. What about belgian franc? What about the Catalan peseta, the Equatorial Guinean peseta, the Sahrawi Peseta? As for the plural form, I can't tell. Maybe it was in the optic of the dev/coder who added the currency. Should it be changed? Would need to get in contact with him/them to check

3. I can't remember, but there should be a very good reason for that...

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9842

PaulC wrote:

2. All other currencies from Austrian Schilling down are distinguished by country, and use of the ISO codes makes peseta and franc specific to Spain and France. Belgian Franc is already there (as is Swiss Franc), the others you mention are pretty obscure.

As for my other point, it just looks a little untidy IMO to use a mix of singular and plural (though for some these are the same). Ideally you want to stick to a single standard.

1. So the existing set of currencies are pretty much fixed then? Is it only possible to use newgrfs to modify existing currencies and not to add them like with town names? Is there the possibility of adding more currencies to OTTD (current selection is a little Euro-centric)?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9843

Yexo wrote:

NewGRF can only change existing currencies, not add any. However unlike what Belugas said there are no technical limitations to reordering the current list. The new dropdown widget is a lot more flexible than it was a few years ago and allows assigning arbitrary ids to items, so that they can be out of order.

As for the mix of singular and plural: "Pounds" is also plural, as is "Dollars", so there is no clear standard about that. Those currencies are also missing a country.

If you think there are some important currencies missing, feel free to list them (along with conversion factors). However I haven't seen a feature request for a new currency in a long time, so apparently the current list is good enough for almost all users.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9847

PaulC wrote:

Thanks, I may request one or more additional currencies at a later date. Just a thought, but how feasible would it be to allow new currencies to be added by newgrf?

In the meantime, can you (or anyone else) tell me what the id's are of the existing currencies (needed for action 0)? The wiki page for currency does not contain this info.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9848

Yexo wrote:

See http://svn.openttd.org/trunk/src/currency.cpp
The index in that list is also the action0 id you need. So 0 = british pounds, 2 = Euro, 10 = spanish pesetas etc.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9849

frosch wrote:

Currencies are a client side thing. As such they are not exposed to NewGRFs to avoid desyncs. I.e. none of the stuff on the TTDP wiki listed for NewGRFs & currencies applies to OTTD.
NewGRF defined currencies would also kind of force every client to use the same currency, which is not wanted.

However, you can define a custom currency in the game options.

Edit: What? Why did we implement those? :o

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9850

PaulC wrote:

Hmmm, I coded a few such grfs for TTDP a few years ago and they seem to work ok (more or less) in OTTD...

Custom currencies via game options is fine, but seems a bit limited if you want to switch between different setups.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9851

frosch wrote:

The currencies are now sorted naturally in r22312.
Someone wants to unify the currency names?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9867

Rubidium wrote:

About # 3: The ISO code in the list is unique, whereas the "sign" isn't necessarily unique though there is a different conversion factor associated with it. E.g. you won't use USD in an American shop, or AUD in an Australian... they would use $, however when you're enumerating/listing/comparing multiple Dollars you need the unique name. That's why the ISO code is used for the list, though the first few currencies are the "obvious" exception to that. Nevertheless, when you're in the game you still want to get shown the normal $ sign and not USD. After all, you're not comparing currencies anymore.

Yes, it might look inconsistent, but that's life... why do so many countries use the same name for their currency when they're not "compatible"? An why do people insist on not explicitly specifying the currency when talking about something. Or does your "local" cashier say "that will be X United States Dollar, please"?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575#comment9898

Rubidium closed the ticket.

Reason for closing: Fixed

In r22813

This comment was imported from FlySpray: https://bugs.openttd.org/task/4575