Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one client can download the map at a time #4574

Closed
DorpsGek opened this issue Apr 4, 2011 · 4 comments
Closed

Only one client can download the map at a time #4574

DorpsGek opened this issue Apr 4, 2011 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 4, 2011

xi opened the ticket and wrote:

Only one client can join server at once. Second client trying to join game is kicked with no message.

Reported version: 1.1.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4574
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 5, 2011

xi wrote:

DEF_GAME_RECEIVE_COMMAND(Client, PACKET_SERVER_WAIT)
{
if (this->status != STATUS_AUTHORIZED) return NETWORK_RECV_STATUS_MALFORMED_PACKET;
this->status = STATUS_MAP_WAIT;

DEF_GAME_RECEIVE_COMMAND(Client, PACKET_SERVER_WAIT)
{
if (this->status != STATUS_MAP_WAIT) return NETWORK_RECV_STATUS_MALFORMED_PACKET;
//this->status = STATUS_MAP_WAIT;


This comment was imported from FlySpray: https://bugs.openttd.org/task/4574#comment9832

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 5, 2011

frosch wrote:

Ah! Completely misunderstood the report at first :o

So, it is about: Only one client can download the map at any time.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4574#comment9833

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 7, 2011

xOR wrote:

I could reproduce that here by simply setting one of my servers to have a quite huge map (12x12, to make sure downloading will take some time even with the new compression) and then trying to connect 2 clients. While the first client is still downloading the map the second client cannot connect, it is simply thrown back to the main menu after the status said "Authorized" for a split second (where in 1.0.5 it would say that it's waiting in the line and eventually start downloading the map, too).

I have run the server with -d net=3 while reproducing it but I only see that a second connection is coming in but disconnected the same second:
dbg: [net] [server] Client connected from X.X.X.X on frame 1733
dbg: [net] [server] Client connected from X.X.X.X on frame 1762
dbg: [net] Closed client connection 5

While the first connection finally finishes its map download and joins:
*** xOR has joined the game (Client # 4)

Now at this point the second client can join, too.

Running 1.1.0 without any patches (on Debian, installed from x64 .deb package).


This comment was imported from FlySpray: https://bugs.openttd.org/task/4574#comment9846

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 9, 2011

Rubidium closed the ticket.

Reason for closing: Fixed

In r22308


This comment was imported from FlySpray: https://bugs.openttd.org/task/4574

@DorpsGek DorpsGek closed this as completed Apr 9, 2011
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant