Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play heightmap -> MakeNewgameSettinsLive() called too soon. #4557

Closed
DorpsGek opened this issue Mar 18, 2011 · 1 comment
Closed

Play heightmap -> MakeNewgameSettinsLive() called too soon. #4557

DorpsGek opened this issue Mar 18, 2011 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

chillcore opened the ticket and wrote:

When generating a heightmap MakeNewgameSettingsLive() is called too soon.

Too see for yourself select the toyland climate from the main menu and click Play Heightmap, before generating the map make sure you resize more than the recommended values.
In addition of the warning you will see the water change to the toyland variant as seen in the first screenshot.

Next refuse to continue and open the NewGRF Settings gui. Upon closing this gui the rest of the intro screen will be changed to the toyland climate as seen in the second screenshot.

In the same way it is possible to change the titlescreen to any desired climate.

Attached patch fixes this by moving MakeNewgameSettingsLive() to the else statement when checking the resizing of the heightmap.

Regards,
ChillCore.

ps:
I doubt that this can be considered a feature as in the moreheightlevels patch this does not happen, instead the game crashes with a segmentation fault, which is what made me find the issue.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4557
@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

The call is needed in both cases, not only the else-case. But StartGeneratingLandscape calls it already anyways.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4557

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant