Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No update of NewGRF window when unknown GRF names come from the network #4533

Closed
DorpsGek opened this issue Feb 24, 2011 · 2 comments
Closed

No update of NewGRF window when unknown GRF names come from the network #4533

DorpsGek opened this issue Feb 24, 2011 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

If we open the NewGRFWindow to show GRFs associated to a network game, name of some GRFs may be unknown (""). When PACKET_UDP_SERVER_NEWGRFS packet comes with some names we didn't have, there is no update to the window, still "" is displayed.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4533
@DorpsGek
Copy link
Member Author

Rubidium wrote:

This seems to be broken by the GRFText stuff for GRFConfig::name; now the string is cloned completely, instead of only passing the reference.

Not sure what the best way to fix this is; one way is creating GRFTexts that use pointers and GRFTexts that use buffers in themselves. The other is checking all GRFTexts whether they might need a name change, but that would involve reallocating the GRFTexts which seems somewhat non-trivial at best.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4533#comment9734

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 3, 2011

Yexo closed the ticket.

Reason for closing: Fixed

In r22162

This comment was imported from FlySpray: https://bugs.openttd.org/task/4533

@DorpsGek DorpsGek closed this as completed Mar 3, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek