Zydeco opened the ticket and wrote:

Trying to reproduce bug # 4497, I found that the server will sometimes crash if a client disconnects just after sending the PACKET_CLIENT_GETMAP packet, although where the crash occurs is different on different OSes.

I've been tracking it a bit under Mac OS X, and it seems to happen when the send() under this->SendPackets() in network_sever.cpp:575 gets a broken pipe error, so it closes the connection and in the ServerNetworkGameSocketHandler destructor, it tries to lock the savegame_mutex that is already locked by the same thread, so it gets a EDEADLK error.

On linux it crashes on a different place, but it is caused in the same way.

To cause the crash I used a ruby script that sends the appropriate packets and disconnects after GETMAP, I'm attaching it too.

Attachments

• crashlog-linux32.txt (5.49 KiB)
• crashlog-osx32.txt (6.37 KiB)
• crashlog-osx64.txt (8.73 KiB)
• bug.rb (2.09 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4503