Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when joining server #4497

Closed
DorpsGek opened this issue Feb 11, 2011 · 3 comments
Closed

Crash when joining server #4497

DorpsGek opened this issue Feb 11, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Zydeco opened the ticket and wrote:

My OpenTTD server crashed when I was joining, and I ran rcon clients on the console. I reloaded it with one of the autosave files, and it crashed again, this is the report from the second crash, but the crash message is the same, the assertion in saveload.cpp

I have attached an autosave from earlier in the game, since the crash.sav was 0 bytes, and also a script that I run that saves password hashes periodically, so I can restore them if the server crashes, when switching versions, or if I have to restart it.
Maybe gdb attaching to the process at the wrong time could cause the crash, but it doesn't call any function in OpenTTD, it only prints data.

Attachments

Reported version: 1.1.0-beta5
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4497
@DorpsGek
Copy link
Member Author

Rubidium wrote:

Since you're familiar with gdb, could you build a debug binary (./configure --enable-debug) and give the stack trace of all threads when OpenTTD hits that assertion?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4497#comment9667

@DorpsGek
Copy link
Member Author

Zydeco wrote:

I think I have found how to reproduce it:
the map must be big enough that it takes a few seconds to save and compress

  1. start joining a server
    - the server will start a thread saving/compressing the game
  2. try to execute a rcon command on the console (the right password is not required!!!) while it's loading before the save thread finishes
    - you will be disconnected with a protocol error
  3. reconnect quickly, before that save thread finishes
    - the server will crash with the assertion failure in saveload/saveload.cpp:2411

I have also attached a backtrace, they are all quite the same, only varying in how deep into liblzma the thread is.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4497#comment9668

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r22064

This comment was imported from FlySpray: https://bugs.openttd.org/task/4497

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek