Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cached return value of CB2D #4493

Closed
DorpsGek opened this issue Feb 9, 2011 · 3 comments
Closed

Updating cached return value of CB2D #4493

DorpsGek opened this issue Feb 9, 2011 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 9, 2011

mb opened the ticket and wrote:

According to the spec, "the return value is cached to speed up sprite processing, and is only updated via callback 32 bit 1 or when loading/starting a game or rearranging the consist".

Apparently, "flipping" an engine in depot doesn´t seem to count as "rearranging", and thus, the return value of the CB doesn´t get updated. However, it gets updated when "switching" direction of travel for that vehicle, either manually or in a station (which isn´t documented, though).

In case, it´d be nice to update the value not only when a "consist is rearranged" in depot, but also when that particular vehicle is being "flipped".

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4493
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 9, 2011

Rubidium wrote:

The cache update upon reversing is needed because of modflags FE bit 8, as some NewGRF developers use it to make trains slower and such. To not get into a desync when clients join the cache update is needed so I guess the wiki has to be clarified and maybe TTDPatch needs to implement this cache invalidation as well.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4493#comment9643

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 9, 2011

Rubidium closed the ticket.

Reason for closing: Fixed

In r22044


This comment was imported from FlySpray: https://bugs.openttd.org/task/4493

@DorpsGek DorpsGek closed this as completed Feb 9, 2011
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 9, 2011

frosch wrote:

Respectively var C8.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4493#comment9644

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant