michi_cc wrote:

You have managed to create more than 64000 orders. Raising that limit is probably not trivial.

Do you use http://wiki.openttd.org/Shared_orders# Shared_orders ?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4468#comment9600

PulsarPL wrote:

Thank you for your reply.
I don't use shared orders. I wasn't aware of that option.
Maybe it's time for a new map.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4468#comment9601

SmatZ wrote:

Raising the limit isn't a solution. If this happens, there is a place where Order::CanAllocateItems() isn't called before 'new Order()'. That's a serious problem, as it can be used to easily DoS a server.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4468#comment9606

SmatZ wrote:

Index: src/vehicle.cpp

--- src/vehicle.cpp (revision 21962)
+++ src/vehicle.cpp (working copy)
@@ -1849,7 +1849,8 @@
Order *in_list = this->GetOrder(this->cur_auto_order_index);
if (in_list != NULL && this->orders.list->GetNumOrders() < MAX_VEH_ORDER_ID &&
(!in_list->IsType(OT_AUTOMATIC) ||
- in_list->GetDestination() != this->last_station_visited)) {
+ in_list->GetDestination() != this->last_station_visited) &&
+ Order::CanAllocateItem()) {
Order *auto_order = new Order();
auto_order->MakeAutomatic(this->last_station_visited);
InsertOrder(this, auto_order, this->cur_auto_order_index);

Something like this can be used to solve this problem, but maybe there are other places that need fixing.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4468#comment9607

SmatZ wrote:

http://devs.openttd.org/~smatz/verify_can_allocate.diff

This patch adds a verification that CanAllocateItem() is called before each operator new. There are many fixes needed just to load the intro game.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4468#comment9608

SmatZ closed the ticket.

Reason for closing: Fixed

r22022

This comment was imported from FlySpray: https://bugs.openttd.org/task/4468