Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vehicles gui does not open when cloning vehicles with shared orders. #4458

Closed
DorpsGek opened this issue Feb 1, 2011 · 1 comment
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 1, 2011

chillcore opened the ticket and wrote:

As titel says.

When cloning vehicles with shared orders they usually share the rest too and changes are not likely to be made between them. (eg.refit, consist, etc)
The guis just clutter the main view and serve no useful purpose in this case. (if someone wants to change something anyway, for whatever reason, he/she can still click the vehicle from the depot ...)

Code below changes the "new vehicle window pops open" behaviour when cloning vehicles with shared orders only.
New vehicle gui still opens when cloning a vehicle normally.
The code affects both cloning from the depot gui and from the vehicle gui.

As the change to make is minor I have posted the code to change instead of a patch ... if needed/prefered I can post one.

Line 144 (as in r21936) in depot_gui.cpp.

- ShowVehicleViewWindow(v);
+ if (!_ctrl_pressed) ShowVehicleViewWindow(v);

Regards,
Chillcore.

PS: Credits to DJ Nekkid for the idea. In the event you wish to include this into trunk you may credit him instead of me. I only found the sweet spot. ;)

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4458
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 9, 2012

frosch closed the ticket.

Reason for closing: Implemented

in r24808, _ctrl_pressed cannot be used in the command callback; ctrl might already been unpressed when the command return from the server


This comment was imported from FlySpray: https://bugs.openttd.org/task/4458

@DorpsGek DorpsGek closed this as completed Dec 9, 2012
@DorpsGek DorpsGek added Clone vehicles flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant