Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash by loading gamesave, Assertion failed at line 153 #4442

Closed
DorpsGek opened this issue Jan 24, 2011 · 5 comments
Closed

crash by loading gamesave, Assertion failed at line 153 #4442

DorpsGek opened this issue Jan 24, 2011 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

muzzy opened the ticket and wrote:

Hi,

I have downloaded gamesave from
http://www.tt-forums.net/viewtopic.php?f=60&t=52545

Crash happens by trying to load saved file.

Attachments

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/4442
@DorpsGek
Copy link
Member Author

muzzy wrote:

I was using openttd-trunk-r21905-windows-win32 version.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4442#comment9528

@DorpsGek
Copy link
Member Author

glx wrote:

KERNELBASE.dll!RaiseException@16() + 0x58 octets
openttd.exe!CustomAbort(int signal=0x00000016) Ligne 547 C++
openttd.exe!raise(int signum=0x00000016) Ligne 590 + 0x4 octets C
openttd.exe!abort() Ligne 71 + 0x7 octets C
openttd.exe!error(const char * s=0x00b2edb4, ...) Ligne 126 C++
openttd.exe!RoadVehAccelerate(RoadVehicle * v=0x00000000) Ligne 668 + 0x25 octets C++
openttd.exe!RoadVehController(RoadVehicle * v=0x0018f408) Ligne 1479 C++
openttd.exe!CallVehicleTicks() Ligne 814 + 0x7 octets C++
openttd.exe!StateGameLoop() Ligne 1213 C++
openttd.exe!GameLoop() Ligne 1301 C++
openttd.exe!VideoDriver_Win32::MainLoop() Ligne 887 C++
openttd.exe!ttd_main(int argc=, char * * argv=) Ligne 763 C++
openttd.exe!WinMain(HINSTANCE
_ * hInstance=0x00400000, HINSTANCE__ * hPrevInstance=0x00000000, char * lpCmdLine=0x00cd3f2a, int nCmdShow=0x00000001) Ligne 431 + 0x9 octets C++
openttd.exe!__tmainCRTStartup() Ligne 263 + 0x1b octets C
kernel32.dll!@BaseThreadInitThunk@12() + 0x12 octets
ntdll.dll!___RtlUserThreadStart@8() + 0x27 octets
ntdll.dll!__RtlUserThreadStart@8() + 0x1b octets


This comment was imported from FlySpray: https://bugs.openttd.org/task/4442#comment9529

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r21916


This comment was imported from FlySpray: https://bugs.openttd.org/task/4442

@DorpsGek
Copy link
Member Author

muzzy wrote:

Reason for closing: Fixed
Additional comments about closing: In r21916

I would like to say that game still crashes with latest
openttd-trunk-r21917-windows-win64.zip game version.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4442#comment9537

@DorpsGek
Copy link
Member Author

Rubidium wrote:

You're trying to load a savegame make with HEQS 0.7.1 with HEQS (preview) 0.4, or with a different version of Long vehicles. It looks like the NewGRF developers made some mistake and did not mark those particular versions incompatible with eachother, even though they are. That makes OpenTTD think it can use the different versions of the NewGRFs even though it can't.

In this case a vehicle's information is replaced with the information of another vehicle; one that isn't articulated, which messes the game state up and eventually causes this crash. In short you're missing the right NewGRFs to load the game, and the NewGRF authors made a mistake by not marking the versions incompatible with eachother (or rather, they made the mistake by saying they are compatible with eachother). It's not something OpenTTD can do much about. Not crashing would mean we wouldn't catch real OpenTTD bugs, which is in my opinion more important than not crashing due to a NewGRF bug (or simply loading the wrong NewGRF).

The first bug was something that a valid NewGRF could trigger, if they design slow enough vehicles. This "disconnection" of vehicles is only something that happens when NewGRFs are changed (in an incompatbile way with eachother).


This comment was imported from FlySpray: https://bugs.openttd.org/task/4442#comment9538

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant