Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing assertion after a click on a industry building #4422

Closed
DorpsGek opened this issue Jan 17, 2011 · 3 comments
Closed

Failing assertion after a click on a industry building #4422

DorpsGek opened this issue Jan 17, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

buygrush opened the ticket and wrote:

Getting a assertion failure / crash after a click on the sawmill at the train station "Vorfurt Höhe".

Attachments

Reported version: 1.1.0-beta3
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/4422
@DorpsGek
Copy link
Member Author

Rubidium wrote:

Reproducable from crash.sav

This comment was imported from FlySpray: https://bugs.openttd.org/task/4422#comment9489

@DorpsGek
Copy link
Member Author

Rubidium wrote:

It triggers the argument type assertion because, for some reason, arguments are overwritten when they come from NewGRFs. It can be easily worked around by setting argt to the return type of RemapNewGRFStringControlCode but that's not a fix at all.

I've tried to assign a new argv/argt for each call to RemapNewGRFStringControlCode but even that doesn't seem to work; it works on the saw mill, but fails on the factory. Even bumping the number of arguments that SCC_NEWGRF_PRINT_STRING_ID "takes" doesn't seem to help (it seems to take 3 arguments instead of just one).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4422#comment9495

@DorpsGek
Copy link
Member Author

Yexo closed the ticket.

Reason for closing: Fixed

In r21885

This comment was imported from FlySpray: https://bugs.openttd.org/task/4422

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek