Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console command 'stopall' (debug builds only) crashes game #4409

Closed
DorpsGek opened this issue Jan 15, 2011 · 2 comments
Closed

console command 'stopall' (debug builds only) crashes game #4409

DorpsGek opened this issue Jan 15, 2011 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Hirundo opened the ticket and wrote:

found in r21800, debug version

steps to reproduce:
- Create a game with a train of at least two wagons (title game suffices)
- Type 'stopall' in the console
- Game crashes with assert (this->First() == this) in GroundVehicle::CargoChanged(), ground_vehicle.cpp:82

This is caused by StopAllVehicles iterating over all vehicles without checking that it's actually a front vehicle.

Fix is attached

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4409
@DorpsGek
Copy link
Member Author

SmatZ wrote:

This command has silly sideeffects, like stopping aircraft in flight. Is there any point in keeping this command available?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4409#comment9464

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Fixed

The command was removed in r21804.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4409

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant