Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Order Keep Piling Up #4404

Closed
DorpsGek opened this issue Jan 14, 2011 · 3 comments
Closed

Auto Order Keep Piling Up #4404

DorpsGek opened this issue Jan 14, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Sylf opened the ticket and wrote:

In the attached save game, created with r21766, the farm trains have non-explicit order to drop their cargoes at the FPP using couple of waypoints. The 2 stations placed between those waypoints keep piling up in the order for those trains until number of orders reach 254. Also, before reaching that many orders in the list, the trains start not following the next explicit orders. Please see the attached save game, then watch it in fast forward for about 4 years, and you should start to see problems.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4404
@DorpsGek
Copy link
Member Author

fonsinchen wrote:

I believe this patch solves at least part of the issue. It does 2 things:

  1. It prevents auto orders from being created if the order list is empty. We cannot tell when the vehicle starts its next "turn" in that case, we even cannot tell if it goes some kind of deterministic route at all.
  2. It removes unreached auto orders not only when reaching an ordered station, but also when reaching an ordered waypoint or depot. This prevents the orders in the given savegame from piling up.

I cannot reproduce the problem with explicit orders not being followed, yet, but I'll try again later.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4404#comment9462

@DorpsGek
Copy link
Member Author

fonsinchen wrote:

I guess I know what you mean by "not following explicit orders". When there are additional (wrong) auto orders between the drop station and the waypoint following it, the order list window suggests that the trains are following one of those auto orders. This is not the case, though. The status bar of the vehicle window shows the "real" order the vehicle is following right now and the arrow in the order list shows which auto order it guesses to reach next. This is slightly confusing, but mostly an effect of the existance of wrong auto orders which the patch fixes.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4404#comment9463

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r2180[789]


This comment was imported from FlySpray: https://bugs.openttd.org/task/4404

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant