Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic orders spawning without non-stop #4391

Closed
DorpsGek opened this issue Jan 8, 2011 · 5 comments
Closed

Automatic orders spawning without non-stop #4391

DorpsGek opened this issue Jan 8, 2011 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 8, 2011

Wolf01 opened the ticket and wrote:

Problem with automatic orders: if not using non-stop the automathic orders will spawn in the vehicles' schedule up to 254 times if the vehicles need to pass through another station of the same type not listed in the real orders.
It might happen to trains too.

See savegame attached, no grfs, plain trunk r21740

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4391
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 8, 2011

Rubidium wrote:

It seems to work just right in r21740. Adding that single station they pass through and stop at is exactly what they're meant to do.

Maybe you don't know what automatic orders are meant for and your concept of it mismatches with how it works. They are inserted whenever a vehicle stops at a station it was not ordered to stop at (by the "current" order). This so the station list of those small stations where you run a "stop train" through get a list of trains passing through without having to specify all stations by hand.

Eventually it will also be useful for things such as cargo destinations whenever you have non-non-stop orders, i.e. the orders you've got for the vehicles in the game.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4391#comment9431

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 8, 2011

Wolf01 wrote:

the real problem will happen when they are full of automatic orders, they start to spawn more because they seem to pass again from the station, I say:
Goto A
Goto B
is the start condition, C is near B

it will become
Goto A
Goto B
Goto C (automatic)

the next loop bad things happen:
a) after unloading to B, the vehicle goes to depot because the servicing is needed, then it might reaches C from the wrong part and again loops through B to come back
Goto A
Goto B
Goto C (automatic)
Goto B (automatic)

b) the first lane of B is full of vehicles, more vehicles want to get around and use the other lane, they first pass through C, then unload at B and again they want to go to C
Goto A
Goto C (automatic)
Goto B
Goto C (automatic)
Goto B (automatic)

In this way I got vehicles to loop in the 2 stations until they reached 252 automatic orders + the 2 real ones.
I thought those automatic orders were there only for information and not to be used as valid orders.
The only solution I found is to force non-stop everytime.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4391#comment9432

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 8, 2011

Rubidium wrote:

In any case, non-stop in this scenario is more or less what you want. Also, automatic orders are not influencing the pathfinding or whatsoever, so it will never go to C by "design"; it will only go there while going from A to B, or from B to A through station C.
Or in other words, if it is facing the right way in station B to go directly, without going through station C, to station A it will go directly and not via station C if the next order is "C (automatic). When arriving at A it will actually remove that "C (automatic)", after all it's automatic and when it's not going there anymore it should not be listed. In this case you'll possibly have some flux in the automatic orders just because of the layout.

So, getting A -> C (automatic) -> B -> C (automatic) -> B (automatic) shouldn't happen and I couldn't reproduce it with your savegame. So, please provide a savegame where the orders do become like that after a few days.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4391#comment9434

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 8, 2011

Wolf01 wrote:

hmmm, maybe it was related to the fixes made for r21740, with this save I can't reproduce it too but when I saw which multiple automatic orders appeared I thought it was the same problem of the other savegame, which might be corrupt (I had to reset all the orders for a couple of routes because they were really stuck going B->C->depot->B->C->depot and never come back to A also without full-load and with 254 orders in list). I think you can close this at it seem to be resolved


This comment was imported from FlySpray: https://bugs.openttd.org/task/4391#comment9435

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 8, 2011

Rubidium closed the ticket.

Reason for closing: Unreproducible

Seems to be fixed by r2173[78].


This comment was imported from FlySpray: https://bugs.openttd.org/task/4391

@DorpsGek DorpsGek closed this as completed Jan 8, 2011
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant