Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with tile 18 #4350

Closed
DorpsGek opened this issue Dec 29, 2010 · 6 comments
Closed

Problem with tile 18 #4350

DorpsGek opened this issue Dec 29, 2010 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

George opened the ticket and wrote:

r12646

I've done some tests with ECS Agricultural Vector and discovered the following misbehaviour with cargo accepting:
The industry has the following layout:
00 01 18
00 02 18
00 00 FE AF 00
01 00 FE AF 00
01 01 FE AF 00
01 02 FE AF 00
so, tiles (0-1) and (0-2) are tile 18
tile (0-1) with land info tool is reported as oil rig
tile (0-2) with land info tool is reported as fishing grounds and always accept passengers.
changing tile 18
996 * 9 00 09 02 01 18
08 18
0E 04
1294 * 39 02 09 F2 82 7C 00 00 07 07
08 80 01 01
80 80 02 02
88 80 03 03
00 88 04 04
08 88 05 05
80 88 06 06
88 88 07 07
00 80
1297 * 14 02 09 FF 81 0C 00 FF 01 F2 00 2B 2B FF 00
1298 * 7 03 09 01 18 00 FF 00
Does not change the situation
What am I doing wrong? How can I make tile 18 have correct cargo accenting (controlled with CBs)? How to make tile (0-1) not be oil rig?

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4350
@DorpsGek
Copy link
Member Author

George wrote:

if I define usage as
00 01 FE 18 00
00 02 FE 18 00
00 00 FE AF 00
01 00 FE AF 00
01 01 FE AF 00
01 02 FE AF 00
station does not appear


This comment was imported from FlySpray: https://bugs.openttd.org/task/4350#comment9359

@DorpsGek
Copy link
Member Author

George wrote:

If I replace default tile
996 * 11 00 09 03 01 18
08 18
09 18
0E 04
station does not appear


This comment was imported from FlySpray: https://bugs.openttd.org/task/4350#comment9360

@DorpsGek
Copy link
Member Author

George wrote:

With this code
996 * 18 00 09 05 01 18
08 18
09 18
0A 00 00
0B 00 00
0C 00 00
station does not appear too


This comment was imported from FlySpray: https://bugs.openttd.org/task/4350#comment9361

@DorpsGek
Copy link
Member Author

Yexo wrote:

The check to build a station is hardcoded to "original id 0x18". It's impossible to really change the properties of any original tile, so you can't make tile type 18 accept anything else than oilrig. The only thing you can do is override them with a new tile. When you override an old tile the effective tile id will be the id of the new tile you've defined in your newgrf. Consequently, as soon as you override original tile 18 and use it it's not really tile id 18 anymore, most likely you've also broken the default oilrig with that change. As such every try at changing tile 18 will result in the station no longer appearing (as you've already seen).

Tile (0-1) is a special tile in the sense that it after the station appears it's no longer an industry tile, it has changed into a station tile. Because it is a station tile you can't set any industry tile properties for it (but see also before, you never could).

In short: there is currently no solution for this. Personally I consider the mechanism to create oil rig tiles broken, but it needs an addition to the specs to fix it.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4350#comment9363

@DorpsGek
Copy link
Member Author

George wrote:

Hope new airports would Allow it. Let's wish more progress on it!


This comment was imported from FlySpray: https://bugs.openttd.org/task/4350#comment9366

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Duplicate

This issue contains some useful background about why oilrig station tiles are not industry tiles.

But #5682 (also from george) is newer and contains a better discussion of why this is a problem for newgrf authors.

Flyspray clean up - closing this one, thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4350

@DorpsGek DorpsGek added NewIndustries flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant