Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure to autorenew (core/GUI desync) #431

Closed
DorpsGek opened this issue Dec 3, 2006 · 3 comments
Closed

failure to autorenew (core/GUI desync) #431

DorpsGek opened this issue Dec 3, 2006 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 3, 2006

Bjarni opened the ticket and wrote:

Since the autorenew bool was moved from the global var to the player struct, the following problem could happen:

Global var (and the patches window) shows autorenew on
Player struct got autorenew off (not visible from GUI anywhere)
Player reads that the settings is on, but the vehicles fails to renew.

A workaround until this is fixed is to turn off autorenew (turns both var off) and then turn it on again (turns both vars on)

In theory turning off the global var and turning on the company var could be possible too, but it has never been reported, only the "failure while on" is reported.

Condition to trigger this is unknown, but it's likely when loading savegames and maybe when more than one player controls the same company. Using cheats to switch to another company might trigger this as well.

Solutions:
Get rid of the global var or make it clear, that it's default setting when starting a company (not any companies already in the game) and add a setting in the game for each company where it's clear that it's for that company only. Some people have talked about other settings that would make more sense to have in a company specific window, so making a new window only with company specific settings might be the best solution. It would also be nice to have a collection of company specific settings so you don't go "now where was it that I control this for my company".

One solution (that would be nice) could be to make such a window and dublicate it in the patches settings so people can set both defaults for new windows and change the current company. If documented right, people will be able to figure this out and it's nice to keep your own default settings like wagon removal (some prefers it to be on by default while others prefer it to be off). The bad part about this is that it would take time to make such a window and I don't have that kind of time right now.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/431
@DorpsGek
Copy link
Member Author

Rubidium wrote:

A temporary fix for this has been committed in r7561, but as stated in the commit message, there needs to be a separate GUI for this.


This comment was imported from FlySpray: https://bugs.openttd.org/task/431#comment734

@DorpsGek
Copy link
Member Author

TrueBrain wrote:

As stated in the last comment, this no longer is a bug, but a feature request: we need a separate GUI for this.


This comment was imported from FlySpray: https://bugs.openttd.org/task/431#comment1857

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

There is no a per-company setting of autorenew that is automatically in-sync with your company


This comment was imported from FlySpray: https://bugs.openttd.org/task/431

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant