fonsinchen opened the ticket and wrote:

Line 1571 in roadveh_cmd.cpp states:

if (v->current_order.IsType(OT_LOADING)) v->LeaveStation();

However, in line 1537 we return from that function if

!v->NeedsAutomaticServicing()

NeedsAutomaticServicing always returns false if v->current_order.IsType(OT_LOADING). Any change to v->current_order between line 1537 and 1571 is coupled with returning from the function so the condition in line 1571 is never true. This is fairly confusing if you're searching for places where LeaveStation can be called.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4295