Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network client loads netwrork_client.tmp from the wrong place #4271

Closed
DorpsGek opened this issue Nov 26, 2010 · 1 comment
Closed

Network client loads netwrork_client.tmp from the wrong place #4271

DorpsGek opened this issue Nov 26, 2010 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

fonsinchen opened the ticket and wrote:

If you have a file ./save/autosave/network_client.tmp you can't join a network game. Openttd will download the actual network_client.tmp to ./.openttd/save/autosave/network_client.tmp and then try to load ./save/autosave/network_client.tmp which of course instantly desyncs. This is obvious if you look at the backtrace:

FioFOpenFileSp (filename=0xaa4a18 "network_client.tmp", mode=0xb80aa1 "rb", sp=SP_FIRST_DIR, subdir=AUTOSAVE_DIR, filesize=0x0)
at /home/alve/projekte/openttd/src/fileio.cpp:345
# 1 0x00000000006dc528 in FioFOpenFile (filename=0xaa4a18 "network_client.tmp", mode=0xb80aa1 "rb", subdir=AUTOSAVE_DIR, filesize=0x0)
at /home/alve/projekte/openttd/src/fileio.cpp:380
# 2 0x00000000008906ce in SaveOrLoad (filename=0xaa4a18 "network_client.tmp", mode=0, sb=AUTOSAVE_DIR, threaded=true)
at /home/alve/projekte/openttd/src/saveload/saveload.cpp:2352
# 3 0x00000000007f0e8e in SafeSaveOrLoad (filename=0xaa4a18 "network_client.tmp", mode=0, newgm=GM_NORMAL, subdir=AUTOSAVE_DIR)
at /home/alve/projekte/openttd/src/openttd.cpp:885
# 4 0x000000000076f9b7 in ClientNetworkGameSocketHandler::NetworkPacketReceive_PACKET_SERVER_MAP_DONE_command (this=0x14af860, p=0x1762150)
at /home/alve/projekte/openttd/src/network/network_client.cpp:749
[...]

Obviously it's allowed to load things from SP_FIRST_DIR (= SP_WORKING_DIR), which it shouldn't.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4271
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r21334


This comment was imported from FlySpray: https://bugs.openttd.org/task/4271

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant