Hirundo opened the ticket and wrote:

Patched against r21228

The current visual effect code works for trains only. The attached series of patches makes the code work step-by-step for RVs and ships as well. Then, implementing CB 0x10 and optionally action0 properties is pretty trivial.

Patch 0 fixes a bug in the positioning of diesel / electric visual effects. The bug being documented in the NewGRF specs doesn't mean that it shouldn't be fixed.
Patches 1-7 generalize the code in a series of steps. I won't go into detail here, see the respective files.
Patch 8 implements callback 0x10 for RVs and ships. Implementation is the same as for trains except that bit 7 (wagon power) is ignored.
Patch 9 changes the default value for visual effect from 0 to 0xFF to prevent corner-case bugs when NewGRFs set the value of the visual effect action0 property to 0.
Patch 10 implements action0 properties for RVs and ships. This isn't a mandatory feature (the CB does everything you may need), but it could be convenient for grf authors.

Also attached is a total diff including all changes, a zip file containing all individual patches and a grf used for testing. This grf gives (intentionally) ill-positioned visual effects to the MPS Regal Bus and the MPS Oil Tanker.

Attachments

• 0_fix_positioning.diff (1.27 KiB)
• 1_generalize_naming.diff (5.12 KiB)
• 2_cached_vis_effect.diff (4.36 KiB)
• 3_vis_effect_enum.diff (6.23 KiB)
• 4_adjust_visualeffect.diff (1.82 KiB)
• 5_move_updateviseffect.diff (5.21 KiB)
• 6_generalize_handlesmokecloud.diff (7.63 KiB)
• 7_move_handlesmokecloud.diff (12.88 KiB)
• 8_feature_smoke.diff (1.85 KiB)
• 9_FF_as_default.diff (2.94 KiB)
• 10_action0.diff (5.54 KiB)
• total.diff (29.21 KiB)
• visual_effect_patches.zip (27.01 KiB)
• CB10.grf (0.26 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4238