Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "City" status to towns list #4186

Closed
DorpsGek opened this issue Oct 26, 2010 · 3 comments · Fixed by #6834
Closed

Add "City" status to towns list #4186

DorpsGek opened this issue Oct 26, 2010 · 3 comments · Fixed by #6834
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Moriarty opened the ticket and wrote:

Hopefully as simple as it seems.
The town directory currently says the following for each entry:

$TOWN_NAME ($POPULATION)

I would simply like to suggest ammending this, at least for cities, to:

$TOWN_NAME (City) ($POPULATION)

Non-cities would remain unchanged. I would suggest saying "City" in a different coloured font too. Maybe white?
This way a user can easily find the cities and give them special treatment if desired.

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4186
@DorpsGek
Copy link
Member Author

sbr wrote:

I was also thinking of that recently.

Towns are wrote with the 'STR_TOWN_DIRECTORY_TOWN' string.

The first patch introduce a new string 'STR_TOWN_DIRECTORY_CITY' that insert " (City)" between the town name and its population. The city status is draw in yellow to highlight it while keeping the same colours as in other brown windows.
The town directory is also made horizontally resizable as the line length now depends of the used language.

The second patch add this new string in all language files that define 'STR_TOWN_VIEW_CITY_CAPTION'.

Please find attached these two patches against r21054 and a screenshot of the town directory.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4186#comment8996

@DorpsGek
Copy link
Member Author

Moriarty wrote:

That's pretty much exactly as I envisioned it. Thanks Sébastien. Now for it to be merged.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4186#comment9001

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Idea looks valid to me - town window already shows '(City)' and this patch simply provides useful consistency.

Tested this on r27895, failed to apply (not surprising given age of patch).

patching file src/lang/english.txt
Hunk # 1 FAILED at 2524.
1 out of 1 hunk FAILED -- saving rejects to file src/lang/english.txt.rej
patching file src/town_gui.cpp
Hunk # 1 FAILED at 636.
Hunk # 2 FAILED at 770.
2 out of 2 hunks FAILED -- saving rejects to file src/town_gui.cpp.rej


This comment was imported from FlySpray: https://bugs.openttd.org/task/4186#comment14608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants