Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on news message #4180

Closed
DorpsGek opened this issue Oct 23, 2010 · 8 comments
Closed

Crash on news message #4180

DorpsGek opened this issue Oct 23, 2010 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

steadypaws opened the ticket and wrote:

I had just unpaused the game to place a rail station and it went BOOM, straight to desktop.

Windows 7 Pro amd64

Attachments

Reported version: 1.0.4
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/4180
@DorpsGek
Copy link
Member Author

steadypaws wrote:

Well, not immediately to desktop. I got the 'crash' dialog to save the game first. ;)


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8961

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Do you have a savegame from before this happened?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8966

@DorpsGek
Copy link
Member Author

glx wrote:

openttd.exe!FormatString(char * buff, const char * str, int64 * argv, unsigned int casei, const char * last) Ligne 980 C++
openttd.exe!GetStringWithArgs(char * buffr, unsigned int string, int64 * argv, const char * last) Ligne 152 C++
openttd.exe!DrawScrollingStatusText(const NewsItem * ni, int scroll_pos, int left, int right, int top, int bottom) Ligne 47 C++
openttd.exe!StatusBarWindow::DrawWidget(const Rect & r, int widget) Ligne 167 + 0x2a octets C++
openttd.exe!NWidgetLeaf::Draw(const Window * w) Ligne 2080 C++
openttd.exe!NWidgetPIPContainer::Draw(const Window * w) Ligne 1091 + 0xc octets C++
openttd.exe!NWidgetPIPContainer::Draw(const Window * w) Ligne 1091 + 0xc octets C++
openttd.exe!Window::DrawWidgets() Ligne 572 C++
openttd.exe!DrawOverlappedWindow(Window * w, int left, int top, int right, int bottom) Ligne 482 C++
openttd.exe!RedrawScreenRect(int left, int top, int right, int bottom) Ligne 1429 + 0x53 octets C++
openttd.exe!DrawDirtyBlocks() Ligne 1515 + 0x5 octets C++
openttd.exe!UpdateWindows() Ligne 2308 C++
openttd.exe!VideoDriver_Win32::MainLoop() Ligne 896 C++
openttd.exe!ttd_main(int argc, char * * argv) Ligne 762 C++
openttd.exe!WinMain(HINSTANCE * hInstance, HINSTANCE
* hPrevInstance, char * lpCmdLine, int nCmdShow) Ligne 430 C++
openttd.exe!__tmainCRTStartup() Ligne 263 + 0x21 octets C
kernel32.dll!BaseThreadInitThunk() + 0xd octets
ntdll.dll!RtlUserThreadStart() + 0x21 octets


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8967

@DorpsGek
Copy link
Member Author

Rubidium wrote:

By the looks of the crash log the crash occured when a news message about an already removed vehicle was shown. To figure what happened exactly we need to have an earlier savegame and information about which vehicles you removed. We could not find any problems by looking at the code.

The best way for us to reproduce this issue is by you reproducing the issue while writing down all steps that need to be done. Once we know the steps and have the initial savegame we can actually determine the cause of the crash and fix that.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8969

@DorpsGek
Copy link
Member Author

steadypaws wrote:

Well, the crashed appeared to happen on the 16th so the last autosave would have been at the beginning of that month. I was converting an obscenely large road vehicle system to be more rail so I did a lot while paused.

I included the last autosave. The timestamps would indicate that about four realtime minutes passed since the save and the crash.

I do know that besides moving to rail that the newer vehicles that I had been autoreplacing to had larger capacities and were speedier so I was obviously experiencing traffic clogs at many raw resource terminals. I had to send many to depots and once things looked settled I would 'clear' the depot by selling them all back at once. I also was changing all the goods transportation to rail so I had the related shared route lists send each of them to stop at a depot once they delivered their cargo. I'd then 'clear' those depots.

I really don't know if I can replicate this error as I don't recall actually doing anything specific. I do remember that vehicle information was set to summary and I would get tons of 'vehicle waiting' messages along with even more 'vehicle x's profit was (negative)' messages. Those could last like 2-3 months into the game to pass. lol

I had also recently removed a road goods depot and 'combined' it with the new rail station by creating a new road depot next to the food factory linking it to the rail's and then updated the road vehicles' orders to drop the resources at the newly combined station. So there may have been some invalid destination messages in the queue. Being the size of the message queue at times, I couldn't even truly begin to fathom what the message could have been. :(

I'll load it up again and see if I can get it to crash again. :)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8970

@DorpsGek
Copy link
Member Author

steadypaws wrote:

Guys, I loaded that autosave and it seems that there were virtually no queued messages waiting. I'm not sure if such messages are stored in a savegame, though. Anyway, I couldn't get it to crash on me again so I'm not sure what to do but play. :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8976

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Sadly enough the news messages aren't stored in the savegame. There are ideas to store the news messages in crash savegames, but sadly enough that doesn't solve or help with the problem that you saw in your game.

At the moment we can't reproduce it, but hopefully/maybe someone can in the near future. Given the fact that not much changed in the area of news messages in the last year it's quite unlikely though.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180#comment8998

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r21458 (we think)


This comment was imported from FlySpray: https://bugs.openttd.org/task/4180

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant