Rubidium wrote:

As OpenTTD doesn't have sand as default... what NewGRF is it? and isn't it the NewGRF's fault?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4172#comment8945

LordAro wrote:

isn't the ton string OTTD though? (i don't understand grfs that well...)

it was firs (0.3 i believe - so if it is it's fault, it will prbably be fixed by now)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4172#comment8946

planetmaker wrote:

We checked FIRS sources, it's something in between, but not limited to FIRS: it has correctly strings for both, singular and plural and defines them as far as I see properly. Somehwhat a problem are the limitations of the string system available to newgrfs here - they cannot easily make use of the same string formatting which default strings can make use of.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4172#comment8949

Belugas wrote:

Sorry that I closed it too soon...
I love closing ;)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4172#comment8952

Rubidium wrote:

Long story short:
NewGRF specs define "one" and "multiple" strings, e.g. respectively "tonne of coal" and "tonnes of coal". OpenTTD wants "units_volume" and "quantifier", e.g. respectively "tonnes" and "{WEIGHT} of coal", although also "{COMMA} bag{P "" s} of valuables" is wanted as well. This to differentiate between SI, Imperial and metric units. The {WEIGHT} is then replaced by "{COMMA} tonne{P "" s}" or "{COMMA} kg".

So the only way I can see this getting fixed is by adding two extra properties that give the values OpenTTD wants. The "units_volume" could be quite easy, although it requires some mapping of (fake) string IDs so NewGRF developers can "invent" new units though there's probably not much more after passengers, tonnes, liters, items, crates and bags. The "quantifier" is more troublesome as we need to export OpenTTD's {WEIGHT}. {VOLUME} and especially the plural stuff for it to work correctly. Luckily no languages use cases for those strings (yet).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4172#comment8953

Rubidium closed the ticket.

Reason for closing: Fixed

In r21224; or at least everything OpenTTD can do about it. The rest is up to the NewGRF developers.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4172