Terkhen wrote:

The lock patch has been committed (with some changes) in r20932.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment8929

uni657 wrote:

Thanks. Do the other two patches (as a concept) fit into OpenTTD style, or they are completely out of the way?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment8930

Terkhen wrote:

IMO showing all possible end tiles is a bit overkill. I think that highlighting only the first possible end tile in the current drag direction would suffice.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment8933

Belugas wrote:

I do have to agree with Terkhen.
Otherwise, same should be done with a lot more than just these mentioned entities. Most revered "consistency" to keep in mind...

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment8951

uni657 wrote:

Build an aqueduct same way as a tunnel. Patch is separated to small parts.
Edit:
added part 9.

Ok, I'll modify bridge highlight patch to show only one tile. It's much more complicated than aqueduct patch, so it'll take some time. FYI it also uses DistanceFromEdgeDir function.

Attachments

• 1 Replace bridge length by constants.diff (2.40 KiB)
• 2 Add DistanceFromEdgeDir function.diff (1.52 KiB)
• 3 Prepare OnPlacePresize.diff (0.86 KiB)
• 4 Change aqueduct to tunnel building style.diff (2.14 KiB)
• 5 Add max bridge length.diff (1.01 KiB)
• 6 Fix error message for aqueduct in OnPlacePresize.diff (0.58 KiB)
• 7 Fix error message for aqueduct in CmdBuildBridge.diff (1.83 KiB)
• 8 Disable highlight if aqueduct is too long.diff (0.98 KiB)
• 9 Remove unused code in OnPlaceMouseUp.diff (0.60 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment8956

uni657 wrote:

Bridge highlight patch, modified to highlight only first valid end tile in the current drag direction. Requires first two parts of the "aqueduct" patch (1 Replace bridge length by constants.diff, 2 Add DistanceFromEdgeDir function.diff).

Attachments

• 3 CanBuildBridgeRamp function.diff (1.24 KiB)
• 4 AllowBridgeRamp function.diff (0.70 KiB)
• 5 AllowBridgeAbove function.diff (1.29 KiB)
• 6 GetBridgeHighlightTile function.diff (2.30 KiB)
• 7 Main part (viewport.cpp).diff (2.84 KiB)
• 8 show next valid tile.diff (2.50 KiB)
• 9 add patch to settings.diff (3.77 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment8964

Rubidium wrote:

I'm not really seeing the point bridge changes. The aqueduct changes are committed though.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153#comment9238

andythenorth closed the ticket.

Reason for closing: Implemented

Partially implemented. Thanks :)

Remainder closed during mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4153