planetmaker wrote:

The crash seems to happen when the parameter window is not entirely covered by the parent window, the newgrf selection window and the "apply changes" button is clicked in that without closing the parameter window.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4125#comment8783

SmatZ wrote:

==3672== Invalid read of size 4
==3672== at 0x6326E7: NewGRFParametersWindow::DrawWidget(Rect const&, int) const (newgrf_gui.cpp:249)
==3672== by 0x789BF5: NWidgetLeaf::Draw(Window const*) (widget.cpp:2085)
==3672== by 0x78750B: NWidgetPIPContainer::Draw(Window const*) (widget.cpp:1022)
==3672== by 0x78750B: NWidgetPIPContainer::Draw(Window const*) (widget.cpp:1022)
==3672== by 0x7891B0: Window::DrawWidgets() const (widget.cpp:547)
==3672== by 0x78EB55: DrawOverlappedWindow(Window*, int, int, int, int) (window.cpp:497)
==3672== by 0x78EB08: DrawOverlappedWindow(Window*, int, int, int, int) (window.cpp:491)
==3672== by 0x78EC32: DrawOverlappedWindowForAll(int, int, int, int) (window.cpp:544)
==3672== by 0x57ECD1: RedrawScreenRect(int, int, int, int) (gfx.cpp:1556)
==3672== by 0x57EECC: DrawDirtyBlocks() (gfx.cpp:1642)
==3672== by 0x7900E4: UpdateWindows() (window.cpp:2431)
==3672== by 0x777642: VideoDriver_SDL::MainLoop() (sdl_v.cpp:581)
==3672== Address 0x87c7620 is 624 bytes inside a block of size 648 free'd
==3672== at 0x4C25A2D: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==3672== by 0x60190C: ClearGRFConfigList(GRFConfig**) (newgrf_config.cpp:332)
==3672== by 0x603237: CopyGRFConfigList(GRFConfig**, GRFConfig const*, bool) (newgrf_config.cpp:348)
==3672== by 0x630B2C: NewGRFConfirmationCallback(Window*, bool) (newgrf_gui.cpp:1605)
==3672== by 0x793027: HandleMouseEvents() (window.cpp:387)
==3672== by 0x7776E4: VideoDriver_SDL::MainLoop() (sdl_v.cpp:429)
==3672== by 0x65176A: ttd_main(int, char**) (openttd.cpp:758)
==3672== by 0x7B63BBC: (below main) (in /lib64/libc-2.11.2.so)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4125#comment8784

Yexo closed the ticket.

Reason for closing: Fixed

In r20812

This comment was imported from FlySpray: https://bugs.openttd.org/task/4125