Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship class and liveries #4124

Closed
DorpsGek opened this issue Sep 14, 2010 · 3 comments
Closed

Ship class and liveries #4124

DorpsGek opened this issue Sep 14, 2010 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Hirundo opened the ticket and wrote:

patch applies to r20806

See also http://www.tt-forums.net/viewtopic.php?f=68&t=49733

The patch is made up of two parts. The first (0_shipclass.diff) adds a new ship property 0x1C 'ship class'. This is similar to train property 0x19. There are three possible values for this property: 0, 1, 2 corresponding to steam, diesel and sail, respectively. All default ships have this property set to 'diesel'

The second part of the patch (1_livery.diff) adds a number of new liveries to the 2cc colour selection window. Currently there are two liveries (passenger ferry / cargo ship) for ships, this patch splits each option in steam/diesel/sail making for a total of six choices. The livery that applies depends on the value of property 0x1C.

As a possible future extension, visual effects (smoke) could be added. This requires some more work to generalise the existing code so it becomes usable for ships.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4124
@DorpsGek
Copy link
Member Author

andythenorth wrote:

Tested with r20806 and a modified version of FISH.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4124#comment8782

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Large Passenger Ferry = Steam
Medium Passenger Ferry = Sail
All other ships default.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4124#comment8807

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2017

andythenorth closed the ticket.

Reason for closing: Won't implement

No longer relevant. Visual effects got done separately though ;)


This comment was imported from FlySpray: https://bugs.openttd.org/task/4124

@DorpsGek DorpsGek closed this as completed Aug 5, 2017
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant