Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too easy to "accidentally" overwrite a saved game #4121

Closed
DorpsGek opened this issue Sep 12, 2010 · 5 comments
Closed

Too easy to "accidentally" overwrite a saved game #4121

DorpsGek opened this issue Sep 12, 2010 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

RAC93 opened the ticket and wrote:

Hi. At times, I find myself accidentally overwriting
a saved game when I'm actually trying to load it.

Can an "optional" warning could be added when you are
about to overwrite a saved game?

There should be an option on the menu to enable it,
as some people are probably fine with the existing
"no warning".

Reported version: other
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/4121
@DorpsGek
Copy link
Member Author

Belugas wrote:

Well... given that every time you save the game, there is a new name been provided, it means that you have voluntary choose an already existing one.
So... hom much protection against yourself would you need???


This comment was imported from FlySpray: https://bugs.openttd.org/task/4121#comment8765

@DorpsGek
Copy link
Member Author

frosch wrote:

I think it is about confusing the save and the load window.
However, you can load a game with doubleclick, but saving requires clicking the button.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4121#comment8770

@DorpsGek
Copy link
Member Author

monoid wrote:

I think there should always be an explicit confirmation from the user before doing anything as irrevocable as overwriting a saved file. I don't agree, however, that it needs to be optional via a setting.

This patch implements such a confirmation.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4121#comment10261

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Patch fails to apply on r27895. I'm not convinced we need this fix, but as the patch is provided, I thought I'd test it. Fixing it might be TMWFTLB.

(Stripping trailing CRs from patch.)
patching file src/fios_gui.cpp
Hunk # 1 FAILED at 239.
Hunk # 2 FAILED at 670.
2 out of 2 hunks FAILED -- saving rejects to file src/fios_gui.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/lang/english.txt
Hunk # 1 succeeded at 2715 (offset 412 lines).
openttd-trunk(master)$ ma
openttd-trunk(master)$ git log -l 1


This comment was imported from FlySpray: https://bugs.openttd.org/task/4121#comment14609

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up, no way forward for this, not a current OpenTTD goal, so closing. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4121

@DorpsGek DorpsGek closed this as completed Sep 2, 2017
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant