Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildings stays under costruction forever #4118

Closed
DorpsGek opened this issue Sep 11, 2010 · 5 comments
Closed

Buildings stays under costruction forever #4118

DorpsGek opened this issue Sep 11, 2010 · 5 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

as opened the ticket and wrote:

In attached savegame some houses stay under construction for ever. Newgrf debug tools shows that the age of the buggy building stays at 0 years even after several game years have passed. The issue seems to be somehow related to animation, as all affected buildings use animation callbacks.

Tested with r20782, in 1.0.4-RC1 houses work normally.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4118
@DorpsGek
Copy link
Member Author

as wrote:

The savegame needs "swedish houses 1.1" grf which is available at online content.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4118#comment8755

@DorpsGek
Copy link
Member Author

Hirundo wrote:

The age of a building remains at 0 while the building is under construction. Does your animation callback expect otherwise?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4118#comment8756

@DorpsGek
Copy link
Member Author

frosch wrote:

MakeSingleHouseBigger() bails out at:
/* means it is completed, get out. */
if (LiftHasDestination(tile)) return;

Remains the question what that check is meant for :p


This comment was imported from FlySpray: https://bugs.openttd.org/task/4118#comment8760

@DorpsGek
Copy link
Member Author

as wrote:

It seems that after r20621 both animation frames for newhouses and status of lift for original ttd buildings 04 and 05 are saved in same location in m7.

The change below fixes the issue, but I don't know much about c++ coding so I don't know if it is the correct way to do it.

- if (LiftHasDestination(tile)) return;
+ if (!(GetHouseType(tile) >= NEW_HOUSE_OFFSET))
+ if (LiftHasDestination(tile)) return;


This comment was imported from FlySpray: https://bugs.openttd.org/task/4118#comment8762

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r20790


This comment was imported from FlySpray: https://bugs.openttd.org/task/4118

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant