Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when loading savegame #4112

Closed
DorpsGek opened this issue Sep 6, 2010 · 4 comments
Closed

crash when loading savegame #4112

DorpsGek opened this issue Sep 6, 2010 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 6, 2010

planetmaker opened the ticket and wrote:

See the attached savegame. It works fine when created as new map. When saved and load the game, OpenTTD crashes.

Easy way to reproduce:
start a game with ttrs3-r18 and firs 0.4. Save that and load it.

Attachments

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4112
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 6, 2010

planetmaker wrote:

Forgot the trees :-) And OpenTTD r20739

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4112#comment8740

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 6, 2010

Yexo wrote:

Most likely fixed in r20754, but it needs testing why firs wasn't disabled in the first case and if it was, why all industries were build.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4112#comment8744

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 8, 2010

foobar wrote:

I did some more testing on the matter. It appears that the Action14 version of the active NewGRFs are not read on gameload. Why I think so:
* From the main menu, the properties of a newgrf show a Version field.
* After generating a new game, the properties of a newgrf show a Version field.
* After saving and loading a game, the properties of a newgrf DO NOT show a Version field.

At that point, FIRS sees TTRS version 0 rather than 18 (or higher) and decides to disable itself. The code in FIRS looks fine to me, see lines 194-198 of this file: http://dev.openttdcoop.org/projects/firs/repository/entry/sprites/nfo/checks.pnfo

This comment was imported from FlySpray: https://bugs.openttd.org/task/4112#comment8748

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 8, 2010

Yexo closed the ticket.

Reason for closing: Fixed

In r20766.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4112

@DorpsGek DorpsGek closed this as completed Sep 8, 2010
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek