OpenTTD

Tasklist

FS#4112 - crash when loading savegame

Attached to Project: OpenTTD
Opened by Ingo von Borstel (planetmaker) - Monday, 06 September 2010, 07:57 GMT
Last edited by Thijs Marinussen (Yexo) - Wednesday, 08 September 2010, 15:36 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version Version?
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

See the attached savegame. It works fine when created as new map. When saved and load the game, OpenTTD crashes.

Easy way to reproduce:
start a game with ttrs3-r18 and firs 0.4. Save that and load it.
This task depends upon

Closed by  Thijs Marinussen (Yexo)
Wednesday, 08 September 2010, 15:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r20766.
Comment by Ingo von Borstel (planetmaker) - Monday, 06 September 2010, 08:01 GMT
Forgot the trees :-) And OpenTTD r20739
   art.tar (141 KiB)
Comment by Thijs Marinussen (Yexo) - Monday, 06 September 2010, 15:24 GMT
Most likely fixed in r20754, but it needs testing why firs wasn't disabled in the first case and if it was, why all industries were build.
Comment by FooBar (foobar) - Wednesday, 08 September 2010, 08:33 GMT
I did some more testing on the matter. It appears that the Action14 version of the active NewGRFs are not read on gameload. Why I think so:
* From the main menu, the properties of a newgrf show a Version field.
* After generating a new game, the properties of a newgrf show a Version field.
* After saving and loading a game, the properties of a newgrf DO NOT show a Version field.

At that point, FIRS sees TTRS version 0 rather than 18 (or higher) and decides to disable itself. The code in FIRS looks fine to me, see lines 194-198 of this file: http://dev.openttdcoop.org/projects/firs/repository/entry/sprites/nfo/checks.pnfo

Loading...