Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip causes crashes with low resolutions #4066

Closed
DorpsGek opened this issue Aug 22, 2010 · 4 comments
Closed

Tooltip causes crashes with low resolutions #4066

DorpsGek opened this issue Aug 22, 2010 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

avd opened the ticket and wrote:

On osx, there seems no minimum size set for the window. It seems that openttd could crash when resize the window at his mimimum.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4066
@DorpsGek
Copy link
Member Author

planetmaker wrote:

That is IMHO a problem with the y-coordinates given to clamp in the TooltipWindow:OnInitialize

See attached patch which makes sure Clamp will always be called with min < max wich currently happens when the window is 1 pixel high and the tooltip with on_hover is called.

Backtrace for the crash was
(gdb) bt
# 0 0x00007fff8723f3d6 in __kill ()
# 1 0x00007fff872df972 in abort ()
# 2 0x0000000100076210 in error ()
# 3 0x0000000100222997 in TooltipsWindow::OnInitialPosition ()
# 4 0x00000001004029cc in Window::InitNested ()
# 5 0x0000000100220fd0 in GuiShowTooltips ()
# 6 0x0000000100405498 in HandleMouseEvents ()
# 7 0x00000001004059b4 in InputLoop ()
# 8 0x00000001002a4949 in GameLoop ()
# 9 0x0000000100407b21 in QZ_GameLoop ()
# 10 0x0000000100405e89 in -[OTTDMain applicationDidFinishLaunching:] ()

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4066#comment8593

@DorpsGek
Copy link
Member Author

avd wrote:

My current steps to reproduce the problem (so far always succeed):

  1. Resize the window till it is smaller then the caption bar of the openttd window ingame
  2. Move that window inside openttd
  3. Crash

So far as I know, the crash only happened in osx. Something tells me it isn't osx only (because it has something to do with something ingame).

Note: before I resized the window, I used the autosnap to align the captionbar with the top of the screen


This comment was imported from FlySpray: https://bugs.openttd.org/task/4066#comment8594

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Might be a bit more serious, easier to trigger, under trunk as there the hover tooltip would happen quite a bit easier than the right-click on, but with that it's still reproducable in 1.0.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4066#comment8598

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r20596; the rest is caused by #4070.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4066

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant