Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo never delivered to station after bribe and before first pickup #404

Closed
DorpsGek opened this issue Nov 16, 2006 · 4 comments
Closed

Cargo never delivered to station after bribe and before first pickup #404

DorpsGek opened this issue Nov 16, 2006 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Anonymous opened the ticket and wrote:

When i created an coal line between an coal station and powerline i decided i wanted more train station space before starting to run trains on it because the production rate was high and 3 coal mines where in reach.
I bribed an town which was close to it which blocked extending the station but the bribe was discovered by a local investigator.

Then i decided then just run the station this way without extending it.
I have had an train on it for a very long time (enough time that the local government funding options come back, thanks to fast forward) but it never starts to load coal anymore (checked and it is correct train, and there is at least 1 coal mine in reach).

The fix was to destroy the station, bribe town, then build new station AFTER the old name dissapeared and it could load coal again.

I have tested this a few times and the same thing happens only when you build a station and before loading cause an investigation failure with bribes, if you allready have cargo running there it doesn't make a difference.

Reported version: 0.4.8
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/404
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 7, 2006

Darkvater wrote:

Confirmed (0.4.8, r7422). When a bribe is discovered the rating for all goods a cargo has/can have is reset to 0. If no cargo has been picked up from the station, the rating will never move away from the zero, most probably an issue in UpdateStationRating()

This comment was imported from FlySpray: https://bugs.openttd.org/task/404#comment685

@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 7, 2006

Darkvater wrote:

#404-cargo_not_delivered_bribe.sav << savegame after bribe has been discovered and no vehicle has visited station.

This comment was imported from FlySpray: https://bugs.openttd.org/task/404#comment686

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2007

TrueBrain wrote:

The problem is kind of funny:

On bribe-fail the rating is reset to 0
When you didn't had cargo moved to that station, enroute_from is NULL
If enroute_from == NULL, rating isn't increased
If rating is 0, you have 0 chance of getting cargo moved to the station

Ergo: chicken-egg problem. Something has to jump-start this to get it to work.

My advise is to make UpdateStationRating check if enroute_from == NULL, and rating < initial value. If so, slowly (rating++) increase the rating back to his original level. Setting the rating to 1 instead of 0 doesn't help, as then you have an other bug: if you start moving a cargo years after a failed bribe, you still start at rating 1 for no clear reason what so ever. This way makes sure that over time, you can't find a trace of a failed bribe.

Patch here: http://devs.openttd.org/~truelight/fs404.patch

This comment was imported from FlySpray: https://bugs.openttd.org/task/404#comment1037

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2007

TrueBrain closed the ticket.

Reason for closing: Fixed

Fixed in revision 9070

This comment was imported from FlySpray: https://bugs.openttd.org/task/404

@DorpsGek DorpsGek closed this as completed Mar 8, 2007
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek