FS#4039 - Train runs through station without pickup up load the 2nd time it visites the station.

Attached to Project: OpenTTD
Opened by G.J. van Trier (gjvantrier) - Monday, 16 August 2010, 21:50 GMT
Last edited by Remko Bijker (Rubidium) - Friday, 20 August 2010, 15:30 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System Mac OS X
Severity Medium
Priority Normal
Reported Version Version?
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Mac OS X 10.6.4
OpenTTD r20486

Train ignores station after visiting it for the 2nd time without unloading prior at drop-station (it just runs through the station without picking up any load).

This only happens when you use a way-point for conditional order checks. If you use a 1-tile station the train will pick up load the 2nd time it enters the station.

There is an save-game attached to show this problem: 4 trains, 3 of them use the way-point and ignore the pickup-station. 1 of them uses the 1-tile-station and acts normal. For the purpose to show this error more clearly I've disabled the other stations so all 4 trains will go through the same station.

This save-game is an edited version of the tutorial example posted at opendttdcoop:
(application/octet-stream)    Srnw2v2.sav (243.1 KiB)
This task depends upon

Closed by  Remko Bijker (Rubidium)
Friday, 20 August 2010, 15:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r20580
Comment by Vít Šefl (Vitus) - Monday, 16 August 2010, 22:11 GMT
This also happens without conditional orders in some cases. Attaching savegame which should help to document this behaviour.
Comment by Remko Bijker (Rubidium) - Monday, 16 August 2010, 22:17 GMT
That's perfectly "normal" behaviour and it is meant to not keep trapped in the same station (and to actually be able to get out of the station). The behaviour of ignoring the station where it last stopped is needed to actually leave the station as that is the only way to determine whether it actually has stopped there or whether it is just entering it for the first time.
Then, whenever it finds that it's heading to a station it resets that variable. What you are doing falls, in my opinion, quite far outside of the scope of the intended use of OpenTTD.