OpenTTD

Tasklist

FS#4029 - windows version detection using hg fails

Attached to Project: OpenTTD
Opened by Hirundo (Hirundo) - Friday, 13 August 2010, 14:51 GMT
Last edited by Jose Soler (Terkhen) - Saturday, 14 August 2010, 09:29 GMT
Type Bug
Category Build system
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In r20482, version detection causes a compile error by returning "" (nothing) as REVISION, breaking rev.cpp.

The command run by determineversion.vbs is this:
"hg log -f -k "(svn r" -l 1 --template "{desc}\n" ../"

When the same command is entered from the command prompt, the following error message is shown:
abort: cannot follow nonexistent file: "."

Removing the -f flag fixes this, so the problem seems to be introduced in r20309

Changing "../" to "--cwd ../" in the command fixes the problem (at least for me), as is done in the attached diff.
This task depends upon

Closed by  Jose Soler (Terkhen)
Saturday, 14 August 2010, 09:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r20488.

Loading...