Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not abort road removal when encountering a road of another player #3971

Closed
DorpsGek opened this issue Jul 24, 2010 · 3 comments
Closed

Do not abort road removal when encountering a road of another player #3971

DorpsGek opened this issue Jul 24, 2010 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Krille opened the ticket and wrote:

The fix in #3882 fixes the reported problem. However, as it is now, there's another problem.

Use the savegame provided in #3882 and build a road over the crossing, then remove it again. Only the road up to the crossing is removed. In 1.0 the entire road, except the crossing, is removed.

The patch will make it that way again.

When building a similar crossing with rails 1.0 acted similarly. Now it will also stop before the crossing. However with rails this is a different thing since a train can't drive over such a crossing anyway. The behaviour matches that of building rails now. I think that part is fine as it is now.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3971
@DorpsGek
Copy link
Member Author

Alberth wrote:

For the next time, please try to keep each error independent. In this case, the title gives no clue what the issue is about, and neither did the description.

We had to re-construct the problem of #3882 first, understand the solution used then, before we could even read this error.
If you had made a better description, and given short summary of the situation and the thing you wanted to change, it would have saved us a few hours.

Of course, it is good (recommended even) to mention other issues in the text.

Summary:
In #3882, when removing a stretch of road, depending on the direction of removal, you got a different error. To preserve the important error 'road owned by other player', the removal was aborted when encountering that error.
Here, the aim is to continue removal again for roads only.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3971#comment8395

@DorpsGek
Copy link
Member Author

Alberth closed the ticket.

Reason for closing: Fixed

in r20215.
Thanks for reporting, and supplying the patch.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3971

@DorpsGek
Copy link
Member Author

Krille wrote:

I first considered to request re-open of the old report since this really is a follow-up report, the issue reported here is caused by the fix used for the old report.

However I decided not to do that. While the decision was made I somehow was under the impression that I couldn't comment and attach into a closed report. I can't remember how that happened. Under that impression I would have had to wait for the re-open request to be processed, but I wanted to get the issue written down and done.

This caused the bad subject of the new report.

I didn't notice that the description of this report, combined with the description of the previous report, is also unclear. Of course everything was clear to me, but since you weren't involved with the previous fix it was all new to you.

So you want a completely separate report for every issue, even if it's directly related to a recent report?


This comment was imported from FlySpray: https://bugs.openttd.org/task/3971#comment8398

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant