Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display speed in vehicle window without truncation #3958

Closed
DorpsGek opened this issue Jul 17, 2010 · 6 comments
Closed

Display speed in vehicle window without truncation #3958

DorpsGek opened this issue Jul 17, 2010 · 6 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues

Comments

@DorpsGek
Copy link
Member

perk11 opened the ticket and wrote:

If you make font size larger (and defaults are rather small), in order to see the speed of vehicle after you clicked on it you should make a vehicle window larger. I request it to automatically change size to fit in the whole string "Goes to STATION_NAME, 100 km/h".

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3958
@DorpsGek
Copy link
Member Author

frosch wrote:

The stationname can be very long, so it is not feasible to make the window big enough to fit the longest possible stationame. You likely also do not want vehicle windows to automatically resize on order change.

So I guess what you rather want is, that only the stationname is truncated when the text does not fit, while the speed remains.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3958#comment8349

@DorpsGek
Copy link
Member Author

perk11 wrote:

I agree with frosch


This comment was imported from FlySpray: https://bugs.openttd.org/task/3958#comment8351

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Could probably re-layout the window a little and fix that. The issue occurs frequently enough, and bugs me.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3958#comment14685

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth wrote:

Patch to vehicle_gui.cpp, plus change all the lang strings. Works fine for a 2-line patch for the stations case. I tried to complete the patch, but have asserts, probably because of parameter order.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3958#comment14741

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@andythenorth
Copy link
Contributor

andythenorth commented Apr 13, 2018

Patching for this was harder than I thought - more lines to touch.

It could be completed, it just needs all the cases for speed handled correctly.

I do think obscuring the speed is a bug FWIW.

@andythenorth andythenorth added bug Something isn't working and removed enhancement from FlySpray labels Apr 13, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) stale Stale issues
Projects
None yet
Development

No branches or pull requests

3 participants