Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

height information for bridge tiles sometimes wrong #3947

Closed
DorpsGek opened this issue Jul 14, 2010 · 5 comments
Closed

height information for bridge tiles sometimes wrong #3947

DorpsGek opened this issue Jul 14, 2010 · 5 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

See the attached screenshot and look at the track on the indicated tracks on bridges. The red circled one should have no reason to be snowy - tiles below and at the same height are not indicated as snowy. The green indicated on on the other hand should be snowy, given the height of the foundations.

That it's to my knowledge not a problem with the newgrf itself show the bridges which are on foundations or one or two height levels lower than those where there are snowy sprites (newgrf attached).

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3947
@DorpsGek
Copy link
Member Author

planetmaker wrote:

hm... this is the screenshots with the circles I talk about. Seems I got the wrong screenshot.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3947#comment8377

@DorpsGek
Copy link
Member Author

frosch wrote:

Some status report :)

Snowyness has been fixed for all tiles.
Remaining is only snowyness on bridges, and on bridgeheads.

For snow on bridges different methods were tried. They all result in the same problem.
The bridge and the track on the bridge is on a different height than the groundtile of the bridgeheads. So either

  1. the track on the bridge has different snowyness compared to surrounding rail,
  2. the groundtile of the bridgehead has different snowyness compared to surrounding groundtiles, or
  3. the track on the bridgeramp has different snowyness than the groundtile. In this case, what snowyness shall the ramp itself get? (If bridgeheads would become newgrf configurable).

Note: Snowyness of bridgeheads is currently not foundation aware, but that is easy to fix if it the rules for snowyness itself are decided.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3947#comment8378

@DorpsGek
Copy link
Member Author

frosch wrote:

My current preference: The entrance edge of the bridgehead defines snowyness. That way the groundtile has the same snowyness than surrounding groundtiles, if it is flat and the track is sloped. And the track has the same snowyness as surrounding track, if the track is flat and the groundtile is sloped.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/3947#comment8379

@DorpsGek
Copy link
Member Author

planetmaker wrote:

I'd prefer the snowyness to have the same height dependence as normal ground tiles have, too: slopes snowy if a ground tile slope would be snowy and the horizontal tracks snowy, if a ground tile of the equivalent height would be snowy, too; this will lead to bridges where only the horizontal part is snowy and the slopes not - but a bump in the height level would be the same, so it is nicely consistent, especially if one considers bridges which have only one sloped bridge head - which is basically what frosch shows in his last png, http://bugs.openttd.org/task/3947/getfile/6355/bridgesnow2.png


This comment was imported from FlySpray: https://bugs.openttd.org/task/3947#comment8383

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 9, 2010

frosch closed the ticket.

Reason for closing: Fixed

in r20420 to r20423


This comment was imported from FlySpray: https://bugs.openttd.org/task/3947

@DorpsGek DorpsGek closed this as completed Aug 9, 2010
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant