Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_settings_client.gui.coloured_news_year misses no_save flag #3916

Closed
DorpsGek opened this issue Jul 2, 2010 · 3 comments
Closed

_settings_client.gui.coloured_news_year misses no_save flag #3916

DorpsGek opened this issue Jul 2, 2010 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jul 2, 2010

Yexo opened the ticket and wrote:

So it's stored in savegames, so also in the 1.0 title savegame. Which means that the value from the config file is overwritten with the value from the title savegame.

Bug is already present (in a slightly different form) in 0.7.5, when you change the value there in a savegame then it won't be changed for new games, only if you change it in the main menu.

Adding the S flag is easy, but it needs figuring out in which savegame version it was added so a load null can be added in place for all versions from that one to current.

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/3916
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2010

frosch wrote:

The setting was added between 0.3.0 (savegame version 2.0) and 0.3.1 (savegame version 2.1).

This comment was imported from FlySpray: https://bugs.openttd.org/task/3916#comment8223

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2010

frosch wrote:

Actually that information is not important :)

Patches are only saved since r3726. So the setting is loaded since the PATS chunk exits.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3916#comment8224

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2010

Yexo closed the ticket.

Reason for closing: Fixed

In r20051

This comment was imported from FlySpray: https://bugs.openttd.org/task/3916

@DorpsGek DorpsGek closed this as completed Jul 2, 2010
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek