Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Railtypes: support for variable or callback "station has_roof" #3914

Closed
DorpsGek opened this issue Jun 30, 2010 · 4 comments
Closed

Railtypes: support for variable or callback "station has_roof" #3914

DorpsGek opened this issue Jun 30, 2010 · 4 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

When using railtypes and station newgrfs together, one will end up with snowy tracks in stations above the snow line - even though the stations feature a nice snow-proof roof.

In order to allow drawing the correct track sprites it'd be nice to have a variable available which returns "has_roof" for a given track tile which can be set by a station set which supports this feature.

A bit open question is as to what to report back in cases where this bit is not set; most probably 'no roof' should be the default as then the result is obtained which a simple terrain check yields.

Or, optionally, one could build on this and define a variable which is not a boolean one but a three or more values variable: no_station, station, and station_with_roof. Then the newgrf authors could decide themselves what to do, IF they also know the newgrf which supplies this station tile.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3914
@DorpsGek
Copy link
Member Author

frosch wrote:

If there would be such a variable, it should also tell about station-supplied groundtype. E.g. concrete or plain earth.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3914#comment8213

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 1, 2017

mb wrote:

When using railtypes and station newgrfs together, one will end up with snowy tracks in stations
above the snow line - even though the stations feature a nice snow-proof roof.

This is a non-existent problem.

The real problem with railtypes and snow is #6407


This comment was imported from FlySpray: https://bugs.openttd.org/task/3914#comment14707

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) NewStations labels Apr 7, 2018
@andythenorth
Copy link
Contributor

@andythenorth
Copy link
Contributor

Let's close, it's not a current priority :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants