Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server hangs when client is joining, 100% cpu usage #3909

Closed
DorpsGek opened this issue Jun 27, 2010 · 1 comment
Closed

Server hangs when client is joining, 100% cpu usage #3909

DorpsGek opened this issue Jun 27, 2010 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

dolly opened the ticket and wrote:

This bug cannot be easily reproduced on real server, because this situation is quite rare. Sometimes it takes days to trigger this on my servers.

When new client is joining server game server just hangs up in infinite loop with 100% cpu usage. 1.0.0 is the last stable version without this bug. This behavior is triggered in NetworkSyncCommandQueue() function when there are some commands on _local_command_queue that should be copied to joining client command queue. When the command is copied pointer reference to next command is not cleared and client command queue has now wrong reference to commands in _local_command_queue which causes infinite for-loop in NetworkSyncCommandQueue() function.

Attached patch should fix the problem.

Attachments

Reported version: 1.0.2
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3909
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r20035. Thanks for the diff.


This comment was imported from FlySpray: https://bugs.openttd.org/task/3909

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant